feat!: Refactor dependabot secrets to pass request by value#4348
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4348 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 193 193
Lines 19519 19526 +7
=======================================
+ Hits 19033 19040 +7
Misses 269 269
Partials 217 217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
dependabot-secrets-request-by-value
branch
from
1de898e to
8b8c923
Compare
|
@gmlewis rebased this PR to make it mergeable as it hadn't been reviewed yet. |
gmlewis
added
NeedsReview
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
|
@stevehipwell - please resolve the conflicts so that we may proceed with this PR. |
…s-request-by-value Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
…-secrets-request-by-value
|
@gmlewis that should be good now. |
|
@gmlewis shouldn't this have been merged before the v89 release was cut given that it was part of a series of changes? RE the TF provider request, speaking as a maintainer there was no rush for the PR where a release was requested. I'd have added this as a comment if I'd thought that I'd block this PR. |
I guess I didn't fully realize the situation over at terraform. It had been over a month since the last release and I was being asked to cut one, so I did. I'm sorry about that, @stevehipwell. We can cut a new one when this series of PRs is completed. |
|
@stevehipwell - if you want these PRs moved along faster, feel free to bring in coworkers or other terraform maintainers to move these along. |
@gmlewis I wish it was that easy. I'll see if I can persuade someone from the TF side to come and help. |
|
@alexandear @Not-Dhananjay-Mishra do either of you have time to give this a quick review? |
3 participants
BREAKING CHANGE:
DependabotServicemethods involving secrets have new params and return values.This PR updates the Dependabot secret update/create functions to use a value parameter (see #3644). This aligns Dependabot secrets with the changes made to actions secrets (#4335) & actions variables (#4346). It also aligns the names of the actions secret and variable request types.